Closed mjsqu closed 3 months ago
For my own future reference, I could have more quickly run my updated tests by doing:
poetry install
poetry run pytest tests/test_tap_mssql.py -k TestSelects -v
poetry run pytest tests/test_tap_mssql.py -k TestInvalid -v
Running all tests requires the build of a database (as supplied by the docker image in the tox.ini
) - but the functionality I was testing didn't require a connection to SQL Server.
These are done:
I ran poetry lock --no-update
but there are no changes as I have made no updates to dependencies
Thank you for adding the version updates. Change approved. Thank you.
Fixes #62 by refactoring the
desired_columns
function to use lists instead of sets as they preserve order. List comprehensions are used to filter the lists rather than a loop. Operations such as intersection, difference and union are also replaced with list comprehensions.Also includes modifications to the existing
TestSelectsAppropriateColumns
:Adds new test
TestInvalidInclusion
which tests that an exception is raised when aninclusion
value of "invalid" is supplied, which is not one of the valid values: