search

winterstein / Eclipse-Markdown-Editor-Plugin

Adds Markdown text editing support to Eclipse
Eclipse Public License 1.0
297 stars 73 forks source link

Improve error handling when GFM plugin is not found #82

Closed PyvesB closed 5 years ago

PyvesB commented 5 years ago

See latest comments in #42.

Rather than opening an obscure error with a link to a GitHub issue, when the plugin detects that GFM Viewer is not installed it can display a more targeted warning suggesting to install it:

gfm

winterstein commented 5 years ago

Thanks @PyvesB

paulvi commented 5 years ago

Great.

Next Q is when is next release...

winterstein commented 5 years ago

Hello Paul,

Good point! Are you handling the release packaging? If I recall correctly, I think the marketplace points to a nodeclipse server. ... yes it does: https://marketplace.eclipse.org/content/markdown-text-editor

All the best,

On Mon, 29 Apr 2019 at 04:25, Paul Verest notifications@github.com wrote:

Great.

Next Q is when is next release...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/winterstein/Eclipse-Markdown-Editor-Plugin/pull/82#issuecomment-487442829, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB6NMAZLLOKEEZYQY424JDPSZTB5ANCNFSM4HI62LSQ .

--

Dr Daniel Winterstein Founder & CTO Edinburgh +44 (0)772 5172 612 http://good-loop.com

paulvi commented 5 years ago

Yes, it is even binary repository, https://github.com/Nodeclipse/nodeclipse.github.io/tree/master/updates/markdown

Not a reference as I was doing mostly later.

So build (mvn package) and put anywhere. Currently many GitHub just put into the same repository, ghpages branch.

There should be even easy way to do it automatically: so to get CD for every PR