winterstein / JTwitter

Java library for using Twitter (+ Identica & Wordpress). Open source under LGPL
http://www.winterwell.com/software/jtwitter.php
69 stars 27 forks source link

AndroidTwitterLogin #8

Open brandall76 opened 11 years ago

brandall76 commented 11 years ago

onPageStarted is called twice. I haven't identified why - It could be an Android OS/device specific for the handling of the WebView.

The first received url is correct, the second is logged as someurl.com/mf.php - therefore verifier == null and onFail is subsequently called

Suggest adding to line 92:

if ( ! url.contains(callbackUrl)) return;

to become:

if ( ! url.contains(callbackUrl) && ! url.endsWith("mf.php")) return;

Or if this is too specific, prevent onFail being called if onSuccess has already been called:

if ( ! url.contains(callbackUrl) && ! success) return;

Where:

boolean success = false;

Is placed inside run() and set to true prior to line 106:

dialog.dismiss(); onSuccess(jtwitter, tokens);

Email me if you need any more info.

Cheers

Ben