WIP: Update charity page - Githubissues

winterstein / sogive-app

The SoGive user app - See your impact

Other

2 stars 5 forks source link

WIP: Update charity page #210

Closed aissshah closed 3 years ago

aissshah commented 4 years ago

WIP Pull Request for Review

this carries on from Anita's pull request
so far, we have only worked on the Impact Calculator on the charity page
putting it on here so others can view it too @anitawoodruff

Would be good to make sure I'm not doing anything glaringly wrong :)

Left to do:

Impact Calculator

[x] Add description of output
[x] font size of description
Analysis
[ ] Add <br /> after questions -- might not be able to change on the front-end
[ ] Display 'learn more about our ratings' link modal box - decide vanilla or bootstrap
Sidebar
[ ] Picture
[ ] Details with pie chart (considering using a react package)
Nav Bar
[ ] Links
[ ] Search bar
Footer
[ ] Add description of output
[ ] privacy policy, terms and conditions link

winterstein commented 3 years ago

Hello @aissshah

Thank you for your work on this. Could you ask @anitawoodruff to review it, and merge it into her branch if she's happy?

I can't safely analyse two PRs with the same branch name (update-charity-page) and different sources -- not without risking a mess in my local git. So I can't really look at this. Sorry.

All the best, Daniel