search

winterstein / sogive-app

The SoGive user app - See your impact
Other
2 stars 5 forks source link

Fixing the text logo placeholder overflow #245

Closed aissshah closed 3 years ago

aissshah commented 3 years ago

Solution to this was to remove the placeholders completely and expand the column when a logo is unavailable.

How it looks now: image

The logo not showing due to a broken link will still be visible.

How it looked before: overflowing text

@anitawoodruff

anitawoodruff commented 3 years ago

Thanks for explaining - makes sense! :)

On Sun, 18 Jul 2021 at 13:22, Aishah @.***> wrote:

@.**** commented on this pull request.

In src/js/components/SearchPage.jsx https://github.com/winterstein/sogive-app/pull/245#discussion_r671834643 :

@@ -433,31 +433,23 @@ const SearchResult = ({ item, CTA, onPick }) => { } data-id={cid}

  • <a
  • href={charityUrl}
  • onClick={onClick}
  • className="logo col-md-2 col-xs-4"
  • {item.logo ? (
  • {item.logo && (

Its a little more concise and removes the need to specify null.. The other option would be sth ? Component : null

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/winterstein/sogive-app/pull/245#discussion_r671834643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOUMW6ERIPXZU3BXUJRD5TTYLBRTANCNFSM5ASA42GQ .