Closed wongws11 closed 3 years ago
Hello Wing -- I've merged this in for testing
Please could you remove sogive.js and form.js from the web-app. Mixing jquery style js and React is likely to cause bugs.
Thanks,
On Tue, 5 Oct 2021 at 10:53, Wing Wong @.***> wrote:
PS I still do not have the writing of FAQ
You can view, comment on, or merge this pull request online at:
https://github.com/winterstein/sogive-app/pull/270 Commit Summary
- bug fixes https://github.com/winterstein/sogive-app/pull/270/commits/91c8561dc252f66ecc3153266ef8f9ed99802ad6
- add form handler back from ori website https://github.com/winterstein/sogive-app/pull/270/commits/475457d408c04c9dcb0dba8dc32dad2829b366dd
File Changes
- M src/js/components/PrivacyPolicyPage.jsx https://github.com/winterstein/sogive-app/pull/270/files#diff-fb3b678a00809de2658c4b9e3e046ab0e1e601d99552d71ecb409d171d84e637 (4)
- M src/js/components/TermsPage.jsx https://github.com/winterstein/sogive-app/pull/270/files#diff-7eb07591dd5abb86ba344817aedb2db548e1c163211c89be61f3c677158ed9a9 (2)
- M src/js/components/WebsiteCards.jsx https://github.com/winterstein/sogive-app/pull/270/files#diff-5b148fe0161611fb18eef0eb5802af063c60cec966202c4cade74c0713a7db5e (16)
- M src/style/WebsiteCards.less https://github.com/winterstein/sogive-app/pull/270/files#diff-ee9b4ea04b36374fb791607ad9428cb761771c25e227b26623ecefc8ad18c879 (5)
- M web/index.html https://github.com/winterstein/sogive-app/pull/270/files#diff-8f62b6ced28d3396b501d2e89a2e7cb761d16cd7dc977aebece03d4a5da5c24e (4)
- A web/js/form.js https://github.com/winterstein/sogive-app/pull/270/files#diff-92226556a5f5399acff09a5e7d06a7712dc6009980fdb9ff2aabfcd5029ab102 (71)
- A web/js/sogive.js https://github.com/winterstein/sogive-app/pull/270/files#diff-1c6cebae63d9e92b4d3119a686c6f43d2a7d4d5c64f3aba956d6dcff24afa683 (122)
Patch Links:
- https://github.com/winterstein/sogive-app/pull/270.patch
- https://github.com/winterstein/sogive-app/pull/270.diff
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/winterstein/sogive-app/pull/270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB6NMBRYKG4IRHOGOJXUHTUFLDIRANCNFSM5FLLSOXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Dr Daniel Winterstein Founder & CTO Edinburgh +44 (0)772 5172 612 http://good-loop.com
PS I still do not have the writing of FAQ