search

winton / acts_as_archive

Don't delete your records, move them to a different table
MIT License
372 stars 87 forks source link

Fix for Issue 24, polymorphic association #26

Open elmatou opened 13 years ago

elmatou commented 13 years ago

Hi Winton, here is a fix for the polymorphic association issue. The point is to check the kind of association (polymorphic and dependent) before calling ReflexionAssociation#klass

elmatou commented 13 years ago

The only problem is the repo owner doesn't maintain anymore this gem.

winton commented 12 years ago

@elmatou Do you have any interest in taking over ownership of ActsAsArchive?

elmatou commented 12 years ago

Hi @winton, I'm not sure to be the best to maintain ActsAsArchive as it relies on others of your gems, and as I'm less on github than before. But I would be glad to fix the little issues we found in the library.

I suggest, you keep the ownership, and add me as a maintener on github and rubygems, and I will push important fixes.

If you are not comfortable with this solution, maybe can you just accept a Pull Request for the two main issues (polymorphic + loading) and then release a new and last version of your gem.

See you

knzai commented 11 years ago

Would it perhaps be a good idea to put a big bold note in the readme that it is unmaintained?

winton commented 11 years ago

Added @elmatou to collaborators and added a note about the project not being maintained.

knzai commented 11 years ago

Thanks winton. I'll see if the client that is using it is willing to be the official maintainer or not.