Closed lchrusciel closed 2 years ago
Hi @lchrusciel, thanks for your PR! I'm OK with Github actions. I haven't use it before and I'm not sure how to turn it on. Would you mind if I add you as collaborator on the repos? So that you can manage it directly and avoid back and forth with my unexisting skills on this topic :) Also, even if I do take care of this package, I think it's a good thing for you guys that someone at Sylius is also able to maintain it, we never know what happens.
Hey Alexandre!
Sure, it would make some stuff easier :) I will probably push forward a few topics here, so probably will ask for your approval now and then.
Sure! I've just invited you as a collaborator on both state machine repos.
Hey Alexandre!
Unfortunately, I don't have enough permissions to do something about GitHub CI yet. Can you check this card:
And see if there is "enable" button. Also, can you check this configuration of the repository:
"Allow all actions" is already checked in the config. In the Actions tab it seems that there is no existing workflow. It looks like we just need to merge this PR to create a new workflow that we will appear in the Action tab. Is the PR ok to merge as is before you go on with a separate one?
I assume, we may try this way 👍
Looks good! I mean, actions are running :p
The current testing pipeline is not working. Either it should be migrated to travis.com or Github actions (or any other CI :)). As we are using GH actions in Sylius and quite happy about it, hence is my proposal.
The build will be almost for sure red now, but to work on it, I would need someone to turn on github action for this repo.
Also, I would recommend start dropping old, unmaintained versions of PHP and Symfony.
/cc @winzou