search

wiqid / repelzen

modules for vcv rack
GNU General Public License v3.0
27 stars 5 forks source link

Reburst time input does not work when a clock source is connected! #25

Open jaffasplaffa opened 1 year ago

jaffasplaffa commented 1 year ago

Hey :)

Been playing around with Reburst and it's a pretty cool module.

But I noticed that if you connect a cable to the clock input, you can only set the time using the time knob, the time input doesn't do anything. I checked the code and it seems like the time input is not connected when the clock input is connected. Line 114 in reburst.cpp, only the time parameter is connected:

Screenshot 2022-10-11 at 22 04 28

Line 114 could be something like: timeParam = params[TIME_PARAM].getValue() + inputs[TIME_INPUT].getVoltage();

I think that might do that job, maybe it needs a bit of scaling, but I think it could work :)

Anyway, just thought i'd mention it. It would be lovely to be able to have time synced bursts, with a changeable sync value, so you can make more fun rhythms, all in sync :)

Best wishes, Jaffa

BarabasGitHub commented 8 months ago

So that's why my idea wasn't working.