Good job

[Aepelzen]

Hi,

good job, these look really nice. The only minor thing I spotted on a quick first inspection is the big knob on the retrig module. It's label says pulsewidth but it is really more like the samplerate. It sets the time-interval at which the input signal is sampled and compared to it's previous value.

I also have some tips and things I discovered while doing my own port in case you are interested:

• the samplerate-converter apparently does not like non-integers ratios. You can improve the refold performance quite drastically by restricting the upsample-ratio to integer values
• The mixer performance can also easily be improved. You can skip channels that are not connected, so you don't have to process the equalizers unnecessarily. Replacing the vu-meter with the new version also helped a lot if I remember correctly. Those simple changes reduced the idle cpu-load (when nothing is connected) from 5% to 1% on my machine
• if you plan to include the sampler in later stages, I recommend putting the sample-display into a buffered widget. That improves performance and also fixes the crashing problems

That's it for now. If you have any questions or need help figuring out how some things work, let me know.

[wiqid]

thanks so much! i will certainly look into your tips.

we do plan on including the sequencers, but not the sampler.

[ShofB]

I wish you would reconsider on the sampler. I have found it very useful.

[wiqid]

the sampler was an unfinished module with known issues. i do not have a particular interest in it. between the nysthi samplers and m80 radio music i think our sample needs are covered.

anyone who wants to pick it up and develop it further can of course do so. the joys of open source!

alternatively, you could ask nysthi's dev to implement features you are missing. he is quite open to requests and quick to respond.