wirbel-at-vdr-portal / w_scan_cpp

w_scan_cpp - test repo. No issues/pull requests here, for latest Version, see it's Homepage, https://www.gen2vdr.de/wirbel/w_scan_cpp/index2.html.
https://www.gen2vdr.de/wirbel/w_scan_cpp/index2.html
GNU General Public License v2.0
12 stars 1 forks source link

Semi-BUG: Reference of the XML DTD is missing #13

Closed lars18th closed 1 year ago

lars18th commented 1 year ago

Hi @wirbel-at-vdr-portal ,

Inside the XML output the address of the DTD is missing:

<?xml version="1.0" ?>
<!DOCTYPE service_list SYSTEM "https://gen2vdr.de/wirbel/w_scan/dtd/service_list.dtd">

<!-- NOTE:
     if reading or writing w_scan XML file format:
        - please validate XML against DTD above.
        - indent each XML element
        - indent using three spaces, don't use <TAB> char to indent.
        - conform to requirements mentionend in DTD file.
 -->

Therefore, I recommend that you add the DTD file to the project source. And if you consider it acceptable, change the URL to the Github raw address. With this change the file will continue to be valid in the future.

And to improve the compatibility, remove the last space in the first line. It will be preferable to use: <?xml version="1.0"?> Regards.

wirbel-at-vdr-portal commented 1 year ago

I was not aware that someone else uses this format at all.

It was lost with the transition from w_scan to w_scan_cpp probably long time ago.

lars18th commented 1 year ago

I was not aware that someone else uses this format at all.

I want to use it as a neutral interchange format to ingest data into other tools. That's the reason to fix the bugs related to it and to expand the tool.

It was lost with the transition from w_scan to w_scan_cpp probably long time ago.

Thank you for the last commits. We can close then the issue?

wirbel-at-vdr-portal commented 1 year ago

Yes. There's also a new example file in doc.

wirbel-at-vdr-portal commented 1 year ago

done.