search

wire-elements / modal

Livewire component that provides you with a modal that supports multiple child modals while maintaining state.
MIT License
1.09k stars 129 forks source link

change min-h-screen to min-h-dvh #403

Closed tanshiqi closed 6 months ago

tanshiqi commented 6 months ago

Adapt to mobile devices with min-h-dvh

PhiloNL commented 6 months ago

Thanks for the PR, I'm closing this for now and I'll look into it for a future major release given it might lead to unexpected behavior.

The sizes of the dynamic viewport-percentage units are not stable even while the viewport itself is unchanged. Using these units can cause content to resize e.g. while the user scrolls the page. Depending on usage, this can be disturbing to the user and/or costly in terms of performance.