search

wireapp / wire-desktop

:computer: Wire for desktop
https://wire.com/download/
GNU General Public License v3.0
1.08k stars 236 forks source link

"linux-other" build (grunt) failure of 3.3.2872 on Fedora Linux 28/Git bisect points out 49feee08/electron-builder as culprit #1784

Closed mandree closed 6 years ago

mandree commented 6 years ago

Wire version: Git tag release/3.3.2872 Wire for web version: (am not getting that far) Operating system: Fedora Linux 28 on amd64 Which antivirus software do you have installed: none

What steps will reproduce the problem?

  1. checkout from Git at release/3.3.2872
  2. adjust DIR and then run the build script below 
    #!/bin/sh
set -ex
DIR="$HOME/VCS-other/wire-desktop.git"   # adjust to your Git clone
cd "$DIR"
npm install
#npm test
grunt -v --arch=x64 --target=rpm linux-other
ls -lbdtr wrap/dist/*.rpm

What is the expected result? An RPM file installable on Fedora Linux with a runnable wire-desktop inside. This used to be possible with older states of the Git repo, for instance, I was able to build 6763f6d (tag: release/3.2.2860, tag: release/3.2.2840, tag: release/3.0.2860, tag: release/3.0.2840)

(Subsequent preface: I am a C programmer, not a Node.js programmer, nor very familiar with Electron. I am trying to build Wire for Fedora natively, rather than using an AppImage, an alien-transformed deb package, or other bulk goods.)

What is the actual result? Build failure.

  1. With npm test, the test stalls (while I have a running older Wire instance active).
  2. Without npm test, I get a build failure as shown below the bisect log.

  3. I have used Git bisect to find the failure inducing change, and it is the one shown right below, commit 49feee08. Data point, note that Signal-Desktop builds on the same computer with electron-builder@20.13.5

    
49feee08bc3882d0b47308c6393897ecb5bfad50 is the first bad commit
commit 49feee08bc3882d0b47308c6393897ecb5bfad50
Author: Florian Keller <ffflorian@users.noreply.github.com>
Date:   Wed Jun 20 12:33:45 2018 +0200

chore: update electron-builder to 20.15.1 (#1553)

:100644 100644 f9fd0ee4bf57d027a9e4b875146141bd346691a0 032e7fef3e464aba72ebff7ef9e6017ddb683d03 M Gruntfile.js :040000 040000 8409dd510b3ab237806814d2ab9a128bf3ea1dc8 88d0d6d6eff7bafe35fa429738a44b4c859edf67 M electron :100644 100644 32583727e6d0bac0f903a072affcdd7f5fb5dafd 507992273aa84d4c15ee9c40a7e5e4969a613947 M info.json :100644 100644 ba88b8736eb23301482f1d938d58b7281f8f5e73 8fc2cfd7b55298c0b303978421f3edbf2557397a M package-lock.json :100644 100644 d45429ab757edcce01c5d4d32199f6dcd8d5147f 7b5c650bd909dfe8bf75c345c485eed29e6d0b28 M package.json

Reading "Gruntfile.js" Gruntfile...OK

Registering Gruntfile tasks.

Registering "grunt-contrib-clean" local Npm module tasks. Reading /home/mandree/VCS-other/wire-desktop.git/node_modules/grunt-contrib-clean/package.json...OK Parsing /home/mandree/VCS-other/wire-desktop.git/node_modules/grunt-contrib-clean/package.json...OK Loading "clean.js" tasks...OK

Registering "grunt-git" local Npm module tasks. Reading /home/mandree/VCS-other/wire-desktop.git/node_modules/grunt-git/package.json...OK Parsing /home/mandree/VCS-other/wire-desktop.git/node_modules/grunt-git/package.json...OK Loading "git.js" tasks...OK

Registering "grunt-gitinfo" local Npm module tasks. Reading /home/mandree/VCS-other/wire-desktop.git/node_modules/grunt-gitinfo/package.json...OK Parsing /home/mandree/VCS-other/wire-desktop.git/node_modules/grunt-gitinfo/package.json...OK Loading "gitInfo.js" tasks...OK

Running tasks: linux-other

Running "linux-other" task

Running "clean:linux" (clean) task Verifying property clean.linux exists in config...OK Files: [no src] -> linux Options: force=false, no-write=false

0 paths cleaned.

Running "update-keys" task Options: config="electron/js/config.js" Reading electron/js/config.js...OK Writing electron/js/config.js...OK

Running "gitinfo" task config.options: cwd=null

local.branch.current.lastCommitAuthor = "Gregor Herdmann" local.branch.current.lastCommitMessage = "feat: Add option to set user data path (#1730)

" local.branch.current.lastCommitTime = "2018-09-14 16:21:37 +0200" local.branch.current.currentUser = Matthias Andree local.branch.current.shortSHA = 95f5102 local.branch.current.SHA = 95f51027f541fd91c2cd0e97e4f8008b8e410f1d local.branch.current.name = HEAD local.branch.current.lastCommitNumber = 1029 remote.origin.url = https://github.com/wireapp/wire-desktop.git

Running "release-prod" task Reading electron/package.json...OK Parsing electron/package.json...OK Writing electron/package.json...OK Releases URL points to https://wire-app.wire.com/win/prod/ OK

Running "bundle" task

Running "electronbuilder:linux_other" (electronbuilder) task Verifying property electronbuilder.linux_other exists in config...OK File: [no files] Options: asar=false, arch="x64", publish=null, linux={"afterInstall":"bin/deb/after-install.tpl","afterRemove":"bin/deb/after-remove.tpl","category":"Network","desktop":{"Version":"3.3.0","Name":"Wire","GenericName":"Wire","Categories":"Network;InstantMessaging;Chat;VideoConference","Keywords":"chat;encrypt;e2e;messenger;videocall","StartupWMClass":"Wire"},"fpm":["--name","wire-desktop"]}, targets=["rpm"] • electron-builder version=20.28.4 • loaded configuration file=package.json ("build" field) Warning: Configuration is invalid.

How to fix:

  1. Open https://electron.build/configuration/configuration
  2. Search the option name on the page.
    • Not found? The option was deprecated or not exists (check spelling).
    • Found? Check that the option in the appropriate place. e.g. "title" only in the "dmg", not in the root. Use --force to continue.

Aborted due to warnings.



Please provide any additional information below. Attach a screenshot if possible.
ffflorian commented 6 years ago

configuration.linux has an unknown property 'afterInstall'

This was fixed in https://github.com/wireapp/wire-desktop/commit/bd4b185d06b272e5ab81b4af5976d2a6e0161543, please use https://github.com/wireapp/wire-desktop/commit/ef41c07c721a25e0953a102c70c0be7c69101dc1 for building.

mandree commented 6 years ago

It seems we're not there yet: trying to build ef41c07 (including git clean -fxd and git checkout -- .), I now get this instead, which is also fatal (meaning there is no output):

Running "bundle" task

Running "electronbuilder:linux_other" (electronbuilder) task
Verifying property electronbuilder.linux_other exists in config...OK
File: [no files]
Options: arch="x64", asar=false, publish=null, linux={"category":"Network","desktop":{"Categories":"Network;InstantMessaging;Chat;VideoConference","GenericName":"Wire","Keywords":"chat;encrypt;e2e;messenger;videocall","Name":"Wire","StartupWMClass":"Wire","Version":"1.1"},"executableName":"wire-desktop"}, productName="wire-desktop", targets=["rpm"]
  • electron-builder version=20.28.4
  • loaded configuration file=package.json ("build" field)
  • writing effective config file=wrap/dist/builder-effective-config.yaml
  • rebuilding native production dependencies platform=linux arch=x64
  • packaging       platform=linux arch=x64 electron=1.8.8 appOutDir=wrap/dist/linux-unpacked
  • cannot unpack electron zip file, will be re-downloaded error=zip: not a valid zip file
  ⨯ zip: not a valid zip file

Warning: /home/mandree/VCS-other/wire-desktop.git/node_modules/app-builder-bin/linux/x64/app-builder exited with code 1 Use --force to continue.

Aborted due to warnings.
mandree commented 6 years ago

BTW which husky version is required these days? I have got husky@0.14.3 here which does not appear to ship a run.js file.

ffflorian commented 6 years ago

You downloaded an invalid Electron zip file. That's not a Wire issue - please try again.

mandree commented 6 years ago

@ffflorian, success after manual intervention as suggested.

However, the will be re-downloaded from my log is not what the system actually did afterwards. Are we looking at an electron-builder bug here, or what part of the build-rig is in charge of the .zip file download?

Plus it appears not all build systems have the same idea of whether they should keep their zip files below ~/.electron/ (dunno whence, possibly Signal-Desktop) or below ~/.cache/electron/ (where the newly downloaded file landed), so bottom line, FTR, rm -rf ~/.cache/electron solved it - brutally. The milder method would probably have been rm -f ~/.cache/electron/electron-v1.8.8-linux-x64.zip.

+ ls -lbdtr wrap/dist/wire-3.4.0-ef41c07.x86_64.rpm
-rw-rw-r--. 1 mandree mandree 38022192 15. Okt 22:30 wrap/dist/wire-3.4.0-ef41c07.x86_64.rpm
ffflorian commented 6 years ago

Hi @mandree, glad to hear the problem was solved. I'll close this issue then. Feel free to comment if there are further questions or problems popping up.