arthurwolf commented 1 year ago

The PR Title
- [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [ ] contains a reference JIRA issue number like SQPIT-764
- [ ] answers the question: If merged, this PR will: ... ³
The PR Description
- [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Briefly describe the solutions you have implemented for the issues explained above.

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Specify here any other facts that you think are important for this issue.

Attachments like images, videos, etc. (drag and drop in the text box)

[ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors
[ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

amitsagtani97 commented 9 months ago

@arthurwolf Can we close this pr, as all the mandarin and rabbitmq specific changes are merged into master now - https://github.com/wireapp/wire-server-deploy/pull/655

arthurwolf commented 9 months ago

@arthurwolf Can we close this pr, as all the mandarin and rabbitmq specific changes are merged into master now - #655

yes this wasn't meant to be actually merged, we can close this.

wireapp / wire-server-deploy