wireapp / wire-server

🇪🇺 Wire back-end services
https://wire.com
GNU Affero General Public License v3.0
2.6k stars 327 forks source link

Move password reset code to AuthenticationSubsystem #4086

Closed battermann closed 1 week ago

battermann commented 1 month ago

https://wearezeta.atlassian.net/browse/WPB-8890

Checklist

fisx commented 1 week ago

one more failure (flake? unrelated? serious?) -

      failure - invalid signature:                                                                   FAIL
        Exception: Error executing request: token invalid
        CallStack (from HasCallStack):
          error, called at test/integration/API/OAuth.hs:417:26 in main:API.OAuth
        CallStack (from HasCallStack):
          error, called at src/Bilge/Assert.hs:101:18 in bilge-0.22.0-6Cxcfrpv0gi69IBgCcDsiP:Bilge.Assert
          <!!, called at src/Bilge/Assert.hs:109:19 in bilge-0.22.0-6Cxcfrpv0gi69IBgCcDsiP:Bilge.Assert
          !!!, called at test/integration/API/OAuth.hs:419:82 in main:API.OAuth
        Use -p '(!/turn/&&!/user.auth.cookies.limit/)&&/failure - invalid signature/' to rerun this test only.
fisx commented 1 week ago

one more failure (flake? unrelated? serious?) -

      failure - invalid signature:                                                                   FAIL
        Exception: Error executing request: token invalid
        CallStack (from HasCallStack):
          error, called at test/integration/API/OAuth.hs:417:26 in main:API.OAuth
        CallStack (from HasCallStack):
          error, called at src/Bilge/Assert.hs:101:18 in bilge-0.22.0-6Cxcfrpv0gi69IBgCcDsiP:Bilge.Assert
          <!!, called at src/Bilge/Assert.hs:109:19 in bilge-0.22.0-6Cxcfrpv0gi69IBgCcDsiP:Bilge.Assert
          !!!, called at test/integration/API/OAuth.hs:419:82 in main:API.OAuth
        Use -p '(!/turn/&&!/user.auth.cookies.limit/)&&/failure - invalid signature/' to rerun this test only.

flake!

fisx commented 1 week ago

integration tests run times on CI:

base line: 9:26:10-9:49:48 => ~23
this PR, last run: 13:54:41-14:15:31 => ~19

not sure how representative these figures are, but they sure don't provide cause for worry. :-)