wireapp / wire-server

🇪🇺 Wire back-end services
https://wire.com
GNU Affero General Public License v3.0
2.6k stars 327 forks source link

Only resend proposals once after external commit #4103

Closed pcapriotti closed 2 weeks ago

pcapriotti commented 2 weeks ago

If the backend somehow ends up with duplicate remove proposals, when an external commit is processed duplicates are now filtered out before resending them.

I still don't know the root cause for the existence of duplicate proposals (#4102 is an attempt at reproducing), but this PR should mitigate the consequence of such an occurrence.

There are no new tests here, because I don't know how to cause duplicate proposals to be stored (short of adding them manually in the test).

https://wearezeta.atlassian.net/browse/WPB-9210

Checklist