wireapp / wire-server

🇪🇺 Wire back-end services
https://wire.com
GNU Affero General Public License v3.0
2.6k stars 327 forks source link

[chore] replace cabal.project.local template and update cabal.project #4119

Closed MangoIV closed 5 days ago

MangoIV commented 6 days ago

Checklist

akshaymankar commented 6 days ago

package: * applies to all packages not just local pacakges. I think this would fail if protobuf stuff which is not provided by nix has any warnings.

MangoIV commented 6 days ago

can we not overwrite in case we run into warnings for these two packages in future? i.e. package * in general and then package proto-lens-protoc ghc-options -Wwarn?

MangoIV commented 6 days ago

in fact, I deleted my cabal store and am trying to build right now, it doesn't look as though it's problematic.

MangoIV commented 6 days ago

currently proto-lens-protoc and hspec-discover do not emit warnings. I have protected us against them failing in future by adding a -Wwarn flag to them. I think this should resolve the objections.

MangoIV commented 6 days ago

There’s even a better option: just don’t use the package stanza at all: https://cabal.readthedocs.io/en/stable/cabal-project-description-file.html#package-configuration-options