search

wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.13k stars 289 forks source link

perf: Improve caching of root js files #17618

Closed atomrc closed 3 months ago

atomrc commented 3 months ago

Description

We currently only cache js files for 5min. But, we don't have a version query params that prevents the browser from using the cache in case a new version is detected. We can then cache the js files "forever" (max allowed caching value is 1 year) and let the v query param handle the cache invalidation.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.17%. Comparing base (a827511) to head (ea2efbe). Report is 2 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #17618 +/- ## ========================================== + Coverage 46.15% 46.17% +0.01% ========================================== Files 762 762 Lines 25023 25023 Branches 5723 5723 ========================================== + Hits 11550 11554 +4 + Misses 12028 12025 -3 + Partials 1445 1444 -1 ```