wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.12k stars 291 forks source link

fix: Conversation scrolling stops loading following messages #17627

Closed przemvs closed 2 weeks ago

przemvs commented 3 weeks ago

https://wearezeta.atlassian.net/browse/WPB-9465

Description

Probably something was wrong while refactoring. Previously we not checking all messages, probably this if checking will fix this issue.

Previously code:

readonly loadFollowingMessages = () => {
    const lastMessage = this.conversation().getLastMessage();

    if (lastMessage) {
      if (!this.isLastReceivedMessage(lastMessage, this.conversation())) {
        // if the last loaded message is not the last of the conversation, we load the subsequent messages
        this.conversationRepository.getSubsequentMessages(this.conversation(), lastMessage as ContentMessage);
      }
    }
  };

Screenshots/Screencast (for UI changes)

Checklist

Important details for the reviewers

(Delete this section if unnecessary)

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (ec97ed0) to head (fef640c). Report is 2 commits behind head on dev.

:exclamation: Current head fef640c differs from pull request most recent head 6455a43

Please upload reports for the commit 6455a43 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #17627 +/- ## ========================================== - Coverage 46.15% 46.14% -0.02% ========================================== Files 760 760 Lines 24993 24992 -1 Branches 5721 5720 -1 ========================================== - Hits 11535 11532 -3 - Misses 12015 12017 +2 Partials 1443 1443 ```
sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud