wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.12k stars 290 forks source link

fix: Do not intercept right click on rendered message links [WPB-6546] #17640

Closed atomrc closed 1 week ago

atomrc commented 1 week ago
BugWPB-6546 Right click on email link opens standard email app instead of option to copy the link


Description

A right click should not trigger the custom click handler and let the browser handle it with the default behavior.

Screenshots

Before

https://github.com/wireapp/wire-webapp/assets/1090716/b0b6cf00-74c4-4f09-80a8-9be91f6110b3

After

https://github.com/wireapp/wire-webapp/assets/1090716/6a36fda0-78ed-4fbe-b484-f300c074031a

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (2e821fe) to head (a7e9542).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #17640 +/- ## ========================================== - Coverage 46.14% 46.14% -0.01% ========================================== Files 760 760 Lines 24992 24990 -2 Branches 5720 5719 -1 ========================================== - Hits 11532 11531 -1 + Misses 12017 12015 -2 - Partials 1443 1444 +1 ```