wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.12k stars 290 forks source link

fix: not clone audio tracks #17645

Closed EnricoSchw closed 23 hours ago

EnricoSchw commented 1 week ago

Description

When you change the audio device during a call, the first track does not terminate and remains enabled in the background. The track should terminate and be closed. However, the track remain indefinitely, until you close the Browser tab. The reason for this behavior is a cloned track that is no longer taken care of.

Screenshots/Screencast (for UI changes)

https://github.com/wireapp/wire-webapp/assets/1362436/4529c0c0-2996-42bd-a779-3b5a200a80b2

Checklist

Important details for the reviewers

(Delete this section if unnecessary)

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (dde8a10) to head (1ef8767).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #17645 +/- ## ========================================== + Coverage 46.13% 46.14% +0.01% ========================================== Files 760 760 Lines 25001 25001 Branches 5720 5720 ========================================== + Hits 11534 11537 +3 + Misses 12023 12020 -3 Partials 1444 1444 ```
EnricoSchw commented 2 days ago

@wireapp/web Reminder

EnricoSchw commented 23 hours ago

@przemvs thx