wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.12k stars 290 forks source link

Global infinite retries cause a lot of problems #17680

Open barryoo opened 3 days ago

barryoo commented 3 days ago

Your Account Type

What steps will reproduce the problem?

Clicking on a contact in the Contacts bar, I want to open a new conversation, but due to network problems, the request fails, and then I click multiple times, which results in multiple retry requests. When the network is restored, multiple conversation appear.

What is the expected behaviour?

Click on a contact multiple times, even if a network problem causes the request to result in, when the network is restored, only one conversation will appear


In api-client, axios-retry is used, so all requests are retried infinite. In fact, it's not just the problem I reported above, but also in other behaviors. This is caused by infinite retries. This issue does not occur in Android/IOS versions. I don't think global infinite retries are a good design, they should be done only when they are really needed, like sending a message.