wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.13k stars 290 forks source link

fix: Correct behavior for CMD/CTRL+k shortcut in new navigation settings (WPB-10006) #17690

Closed thisisamir98 closed 1 month ago

thisisamir98 commented 2 months ago
BugWPB-10006 [Web] Pressing Cmd/Ctrl+k in new navigation settings, settings page stays


Description

This PR addresses an issue where pressing CMD+k (on Mac) or CTRL+k (on Windows/Linux) in the new navigation settings does not behave as expected.

Steps to Reproduce

  1. In the new navigation, go to settings.
  2. Press the shortcut “CMD + k” on Mac or “CTRL + k” on Windows/Linux.

Expected Behavior

Actual Behavior

Fix

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.

Project coverage is 46.32%. Comparing base (4ccfbd6) to head (f93a066). Report is 34 commits behind head on new-navigation.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## new-navigation #17690 +/- ## ================================================== - Coverage 46.41% 46.32% -0.10% ================================================== Files 779 774 -5 Lines 25184 25198 +14 Branches 5760 5763 +3 ================================================== - Hits 11689 11672 -17 - Misses 12030 12060 +30 - Partials 1465 1466 +1 ```