wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.14k stars 290 forks source link

runfix: don't show fav folder in folders [WPB-9511] #17804

Closed PatrykBuniX closed 3 months ago

PatrykBuniX commented 3 months ago
BugWPB-9511 [Web] Marking convo as favorite creates custom folder containing all conversations


Description

We were missing a check if the custom folder is not a favorites folder. Favorites folder should not appear in custom folders list because there's a separate section for favorite conversations.

Screenshots/Screencast (for UI changes)

Before:

Screenshot 2024-07-22 at 13 43 58

Now:

Screenshot 2024-07-22 at 13 43 04

Checklist

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.25%. Comparing base (78f4956) to head (216c3d3). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #17804 +/- ## ========================================== - Coverage 46.26% 46.25% -0.01% ========================================== Files 770 770 Lines 25157 25158 +1 Branches 5751 5751 ========================================== - Hits 11639 11638 -1 - Misses 12046 12047 +1 - Partials 1472 1473 +1 ```
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud