wireapp / wire-webapp

👽 Wire for web
https://app.wire.com
GNU General Public License v3.0
1.13k stars 290 forks source link

Regression in recovering from network change #9964

Open maximbaz opened 3 years ago

maximbaz commented 3 years ago

Your Account Type

What steps will reproduce the problem?

When network drops (connect / disconnect VPN, put computer to sleep and then wake it up), Wire no longer is able to receive new messages, it will just show frontend but there will be no new messages arriving, there will be no loading bar on top, no errors, etc. I can send messages but not receive them.

This is a regression because I fixed it some time ago (https://github.com/wireapp/wire-webapp/pull/5708), but it started happening some again within the past month, a quick look suggests that maybe it was caused by this (https://github.com/wireapp/wire-webapp/pull/9751)? I haven't made the analysis of the new code, but maybe the old analysis will help you narrowing this down (https://github.com/wireapp/wire-desktop/issues/1129#issuecomment-437965302)?

Please feel free to ping me if you have any questions or want a help with testing 😉

What is the expected behaviour?

After network change, Wire is able to reconnect reasonably quickly, without me having to refresh the tab.

Which browser are you using?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36

Installed browser addons

None

sebastian-zero commented 2 years ago

Same issue, wire (Linux) stops working when I resume notebook after suspend.