search

wirecardBrasil / moip-sdk-ruby

Cliente em Ruby para integração server-side com APIs Moip v2
MIT License
29 stars 27 forks source link

Create escrow release #76

Closed ruanltbg closed 4 years ago

ruanltbg commented 6 years ago

There is no way to release an escrow by the SDK. I had to do it manually as:

moip_api.client.post('/v2/escrows/ECW-ID/release', '')

It would be great to have this inside the SDK, something like:

moip_api.escrow.release('ECW-ID')

Doc: https://dev.moip.com.br/v2/reference#libera%C3%A7%C3%A3o-de-cust%C3%B3dia

bressani commented 6 years ago

Hello!

It's on our backlog, but probably it's not going to be developed in the next few weeks, due to the very small team that takes care of the Moip's SDKs.

But feel free to send us a PR with this feature. 😄

Thank you very much!

mateusluizfb commented 6 years ago

Any news? Can I do the changes and make the PR?

ruanltbg commented 6 years ago

@mateusluizfb Yes, for me.

bressani commented 6 years ago

Hello @mateusluizfb and @ruanltbg , it's about to be released:

https://github.com/moip/moip-sdk-ruby/pull/80/commits/ef61c2d0ad903a0944f2b69348421f697ae04914

@MbNakaya can you help them with this, please?

mateusluizfb commented 6 years ago

@bressani nice! Thanks for the update!

mateusluizfb commented 5 years ago

Any news?

ruanltbg commented 4 years ago

The code is merged into master, I will close this.