wiredmax / react-flags

Flags of the world react component
MIT License
86 stars 28 forks source link

Some flags missing #21

Open andyford opened 5 years ago

andyford commented 5 years ago

Hello, I'm using this lib in conjunction with i18n-iso-countries which has a few countries not covered by react-flags. Some are administered by other countries and do not have their own unique flags, but some at least have their own coat of arms, and some even do have their own flags.

Here is the list of missing countries/territories that I found along with their 2 digit ISO country code, international telephone calling code prefix, short note about their flag and/or coat of arms, and related Wikipedia reference...

Bonaire, Sint Eustatius and Saba [BQ, +599] (also: "Caribbean Netherlands", Netherlands flag, own coat of arms) https://en.wikipedia.org/wiki/Caribbean_Netherlands

Bouvet Island [BV, +0] (Norway flag) https://en.wikipedia.org/wiki/Bouvet_Island

British Indian Ocean Territory [IO, +246] (Own flag, own coat of arms) https://en.wikipedia.org/wiki/British_Indian_Ocean_Territory

French Guiana [GF, + 594] (France flag, own coat of arms) https://en.wikipedia.org/wiki/French_Guiana

Guadeloupe [GP, + 590] (France flag, own official logo) https://en.wikipedia.org/wiki/Guadeloupe

Heard Island and Mcdonald Islands [HM, +0] (Australia flag) https://en.wikipedia.org/wiki/Heard_Island_and_McDonald_Islands

Kosovo [XK, + 383] (own flag and own coat of arms) https://en.wikipedia.org/wiki/Kosovo

Reunion [RE, + 262] (France flag, own coat of arms) https://en.wikipedia.org/wiki/R%C3%A9union

Saint Pierre and Miquelon [PM, + 508] (France flag, own coat of arms) https://en.wikipedia.org/wiki/Saint_Pierre_and_Miquelon

Sint Maarten (Dutch part) [SX, +1] (own flag and coat of arms) https://en.wikipedia.org/wiki/Sint_Maarten

Svalbard and Jan Mayen [SJ, +47] (Norway flag) https://en.wikipedia.org/wiki/Svalbard_and_Jan_Mayen

United States Minor Outlying Islands [UM, +0] (USA flag) https://en.wikipedia.org/wiki/United_States_Minor_Outlying_Islands

spitchaiah commented 5 years ago

thanks @andyford for raising this & I'm also facing the same issue. I think there are 2 types of scenarios with this issue.

Issue#1. Country flag icon are already present in vendor folder but its icon is rendered as ? (unknown) in the UI. Issue#2: Country flag icon is not present for certain countries

My guess is, for issue#1, in the react-flags.js file on line#1612, we need to add the two digit ISO codes of the missing country flags to module.exports = {"flags": [];} array . Eg: The iso-2 code for missing "British Indian Ocean Territory" country flag (IO) is missing in this array but its flag icon IO.svg is already present in vendor folder. I could be wrong but this is what I could find so far.

Admins: If this is the change that is needed for #1, I would be happy to create a PR to add the missing iso2 code of those countries. Please let me know. thanks!

image

-Somu

m-rossini commented 4 years ago

Also I would like to point out some other missing flags: Northern Ireland Catalonia Galicia Andalucia Asturias Provence Brittany Silesia

And finally for the purpose of any historical application some non existent countries (Not sure if you want to support that): Yemen Arab Republic Soviet Union Yugoslavia Czechoslovakia

m-rossini commented 4 years ago

A few more regions/countries: Guadeloupe Bohemia Moravia Manchuria Manchukuo German DR Saarland Dahomey Upper Volta Rhodesia South Vietnam North Vietnam Western Australia Gold Coast