search

wiremock / helm-charts

Helm Chart for Wiremock deployment on Kubernetes
https://wiremock.github.io/helm-charts/
Apache License 2.0
19 stars 31 forks source link

WIREMOCK_OPTIONS env var is ignored #28

Closed sigurdblueface closed 3 weeks ago

sigurdblueface commented 11 months ago

Proposal

WIREMOCK_OPTIONS env variable seem to have zero effect on actual application.

App starts listening on 8080 instead of 9021 configured in the variable and ignores all other settings also.

log:

port:                         8080
enable-browser-proxying:      false
disable-banner:               false
no-request-journal:           false
verbose:                      false

values:

WIREMOCK_OPTIONS: "--verbose,--port=9021,--max-request-journal=1000,--local-response-templating,--root-dir=/home/wiremock/storage"

Reproduction steps

install app, enjoy crashloop due to liveness pointing to 'incorrect' port

References

No response

sigurdblueface commented 11 months ago

i see, it is deprecated https://github.com/holomekc/wiremock#breaking-change--23501 one should add args: section for container template

sigurdblueface commented 11 months ago

please see PR #29

gungorerhan commented 8 months ago

please see PR #29

I also need these changes. It would be great if someone can review and merge changes.