Adding support for imagePullSecrets + cleanup using helpers.tpl.
Details
The helm charts currently do not support imagePullSecrets, which is often needed if the enduser wants to provide a private repository for their images. This PR adds support for that
The PR also cleans up labels and selectorLabels to avoid duplication across files, and defines them in _helpers.tpl instead, cleaning up the chart.
Update service.name in ingress.yaml to point to "wiremock.fullname". This avoids issues where the user uses a name other than wiremock as the helm release name during installation. (If something else is used, currently the ingress resource starts pointing to a non-existent resource since the service created has its name set to fullname
Proposal
Adding support for
imagePullSecrets
+ cleanup usinghelpers.tpl
.Details
imagePullSecrets
, which is often needed if the enduser wants to provide a private repository for their images. This PR adds support for thatlabels
andselectorLabels
to avoid duplication across files, and defines them in_helpers.tpl
instead, cleaning up the chart.service.name
iningress.yaml
to point to"wiremock.fullname"
. This avoids issues where the user uses a name other thanwiremock
as the helm release name during installation. (If something else is used, currently theingress
resource starts pointing to a non-existent resource since the service created has its name set tofullname
References:
Submitter checklist
#help-contributing
or a project-specific channel like#wiremock-java
References
https://github.com/wiremock/helm-charts/pull/33