search

wiremock / wiremock-docker

Wiremock Docker image
https://hub.docker.com/r/wiremock/wiremock
MIT License
218 stars 101 forks source link

Improve image extendability #40

Closed lsouchard closed 3 years ago

lsouchard commented 3 years ago

Hello!

I just found your docker image and I like it a lot. However, I need to integrate it into a CI where I won't be able to mount volumes with my stubs and extensions for what I want to do. So I plan on extending your image. If that poses no issue for the stubs, it does for extensions as I can add them to the image but not add the "--extensions" to the existing command or entrypoint without overwriting them.

Could it be possible to add an option of providing args to the existing command and entrypoint when extending your image? Maybe simply by adding an environment variable WIREMOCK_ARGS (like JAVA_OPTS) to append at the end of the command and entrypoint?

lsouchard commented 3 years ago

My mistake, wiremock-docker/samples/random/Dockerfile shows that extending with CMD will do the trick even though it will not allow extending the default entrypoint.