wiremock / wiremock-docker

Wiremock Docker image
https://hub.docker.com/r/wiremock/wiremock
MIT License
210 stars 99 forks source link

#78 - Add support for WireMock CLI options as environment variable #90

Closed kapishmalik closed 8 months ago

kapishmalik commented 8 months ago

This PR adds option to pass wiremock options as env variable to docker file and use it from helm chart.

References

Resolves - https://github.com/wiremock/wiremock-docker/issues/78

Submitter checklist

kapishmalik commented 8 months ago

@oleg-nenashev no change is required on alpine as I have done change at common script docker-entrypoint.sh which is being invoked in both Dockerfiles. Also, integration test written are using testcontainer. Is there any mechanism to set environment variables.

oleg-nenashev commented 8 months ago

There is another entry point for alpine https://github.com/wiremock/wiremock-docker/blob/main/alpine/docker-entrypoint.sh

oleg-nenashev commented 8 months ago

And yes, there is a GenericContainer#withEnv() method

kapishmalik commented 8 months ago

@oleg-nenashev incorporated review comment changes.