wiremock / wiremock-docker

Wiremock Docker image
https://hub.docker.com/r/wiremock/wiremock
MIT License
218 stars 101 forks source link

Fix WIREMOCK_OPTIONS duplicated #92

Closed jerosa closed 11 months ago

jerosa commented 11 months ago

References

Bug: https://github.com/wiremock/wiremock-docker/issues/91

When passing the wiremock options sometimes fail. This is due the WIREMOCK_OPTIONS being duplicated. I've tested it in the entry point.sh adding -x for tracing.

❯ docker run -e WIREMOCK_OPTIONS='--container-threads=100 --verbose' wiremock/wiremock:test-opts
+ '[' '' = '' -o '' = - ']'
+ set -- java -cp '/var/wiremock/lib/*:/var/wiremock/extensions/*' wiremock.Run --container-threads=100 --verbose
+ '[' '' '!=' '' ']'
+ exec java -cp '/var/wiremock/lib/*:/var/wiremock/extensions/*' wiremock.Run --container-threads=100 --verbose --container-threads=100 --verbose
2023-10-20 09:25:02.700 Verbose logging enabled
Exception in thread "main" 
Exception: java.util.MissingResourceException thrown from the UncaughtExceptionHandler in thread "main"

Submitter checklist

kapishmalik commented 11 months ago

@jerosa thanks for fixing this. You also need to fix in this file as well - https://github.com/wiremock/wiremock-docker/blob/main/alpine/docker-entrypoint.sh

jerosa commented 11 months ago

@kapishmalik solved also in that file