Http and https on same instance

[dogruis]

Proposal

With your 3.1.0 version I have to use @EnableWireMock{{@ConfigureWireMock(port = 8081)}, @ConfigureWireMock(useHttps = true, port = 8082)} To have http and https enabled

I would prefer to use

@EnableWireMock(@ConfigureWireMock(port = 8081, httpsPort = 8082)

This would save me from having the need to spin up two wiremock instances.

Edit: I don't know if you have access to this documentation but it need to be updated to reflect your changes. https://wiremock.org/docs/solutions/spring-boot/

References

No response

[tomasbjerre]

Do you have any suggestions for naming the properties?

[dogruis]

I think it should follow the same naming convention as the wiremock-standalone project: https://wiremock.org/docs/junit-jupiter/ port and httpsPort

Or here https://github.com/wiremock/wiremock/blob/master/src/main/java/com/github/tomakehurst/wiremock/core/WireMockConfiguration.java

[tomasbjerre]

And if you dont want to have static ports. How do you want to enable it?

[dogruis]

I guess just using httpsEnabled=true is good enough

[dogruis]

Generally I only need http or https. In some cases I want both but then I specify the static port numbers. It depends on the use case

[tomasbjerre]

Perhaps one way to solve this is to:

• Add new httpsPort option in the annotation
• Make it -1 by default (disabled). Setting it to 0 would be random port and any other value static port.
• Also add new properties for the https port and the https base url
• Probably remove the enableHttps boolean

[tomasbjerre]

On top of that with version 3.1.0

@EnableWireMock{{@ConfigureWireMock(port = 8081)}, @ConfigureWireMock(useHttps = true, port = 8082)}

When I use this it is breaking my spring application context for some reason.

Probably because they both have the same name. But hard to be sure without your log. I submitted a PR that will give an error when same name is used. #63

[tomasbjerre]

PR available with example test case that uses HTTP and HTTPS #64

[tomasbjerre]

Also regarding the documentation on the website. I prefer that to be very minimal and refer users to the running examples here in the repository. I think running examples are trustworthy for users and easy to maintain for me.

[tomasbjerre]

Released in 3.2.0

[dogruis]

Awesome