wiremock / wiremock

A tool for mocking HTTP services
https://wiremock.org/
Apache License 2.0
6.18k stars 1.41k forks source link

TestNotifier.get{Level}Messages return a snapshot #2762

Closed Mahoney closed 2 weeks ago

Mahoney commented 2 weeks ago

Prevents a client adding messages without calling error or info on TestNotifier by modifying the Lists returned by getInfoMessages and getErrorMessages.

More immediately usefully, saves a client from getting ConcurrentModificationExceptions when iterating over the List returned by those methods if other threads are concurrently altering them, which should stop WebhooksAcceptanceViaPostServeActionTest.firesASingleWebhookWhenRequested (and others?) being flaky.

Submitter checklist