Workflow for integration

[Anticept]

To facilitate efficient integration of advdupe2, we're following a simple workflow plan. Basically, we need to:

• [x] import advdupe2 and examine the codebase, and make sure it's worth the effort to integrate into wiremod.
• [x] re-license it to apache 2; the permission from the developers have already been obtained.
• [x] fix the codebase such that we can remove the compatibility workarounds and hacks placed into the Wiremod codebase.

Once this is done then the integration milestone will be considered complete, and this issue thread closed.

A new issue thread will then be opened for deployment, which will serve the purpose of pushing adv dupe 2 to the workshop.

Please do not use this thread for chatter or issue reporting. It exists to comment on the status of this milestone, and to determine when it is appropriate to move on to deployment.

[TomyLobo]

So, is it versioned on Git somewhere already? If not, who's gonna convert it from SVN?

[AbigailBuccaneer]

@TomyLobo: I've used svn2git before, I'll do it.

[AbigailBuccaneer]

@Anticept: What are the GitHub usernames of the original developers?

[TomyLobo]

Alright, I used the email addresses they used on google code. @emspike You're already associated correctly, so your commits should count toward your github stats :) @tbzipper You need to make a github account with that email address or associate it to an existing account if you have one

@ both of you: If you don't like that I used those addresses, I can change them to other addresses too. I can make different names show up in the commit log, too. Just say how you want it :)

[Anticept]

I have added @emspike to the wiremod devs. I am contacting tb

[TomyLobo]

@Anticept contact both

[TBbadmofo]

I'm here.

[Anticept]

@TBbadmofo added

[Anticept]

@AbigailBuccaneer the usernames are TBbadmofo for TB, and emspike as himself.

[TomyLobo]

@TBbadmofo can you associate the address you used on google code with your account?

github associates commits via email addresses

[TBbadmofo]

@TomyLobo Like create a new account or does github let me link it to this account?

[TomyLobo]

The later

If the following link starts showing TBbadmofo instead of tbzipper, it worked: https://github.com/wiremod/advdupe2/commits/master

[Anticept]

Looks like it's linked now. By the way @TomyLobo, it's "latter" :)

[AbigailBuccaneer]

Right, as far as I can see, all the stuff we did in WIremod to deal with advdupe2 is fixed - The big one was class aliases, which is fixed in 561f8d6b5656ea283f6de0727339e2eaf3bdee55 - there was also NetworkVars not working which was standing in the way of some refactoring, which was fixed in 4891aa707bd9b487d22f36c61717f7c4e1ac215f.