wiremod / advdupe2

Advanced Duplicator 2
http://wiremod.com
Apache License 2.0
90 stars 60 forks source link

Fixed a crash exploit #462

Closed NotAPorcupine closed 7 months ago

NotAPorcupine commented 7 months ago

Spawning props with model scale set to 0 crashes dedicated servers. By adding this line of code, the MakeProp function will skip anything with ModelScale set to 0. Developers can modify this part of the code to detect people attempting to crash their server.

thegrb93 commented 7 months ago

Can you report to garrysmod-issues as well?

thegrb93 commented 7 months ago

Clamping the scale, 1e-5 to 1e5, would be better than just checking if its 0.

NotAPorcupine commented 7 months ago

Can you report to garrysmod-issues as well?

Where to do this?

thegrb93 commented 7 months ago

Can you report to garrysmod-issues as well?

Where to do this?

https://github.com/Facepunch/garrysmod-issues