wiremod / advduplicator

Garry's Mod add-on that allows a player to save and load contraptions
http://www.wiremod.com
Apache License 2.0
67 stars 43 forks source link

Added IsAllowed and DoNotDuplicate check. #67

Closed Grocel closed 9 years ago

Grocel commented 9 years ago

It should be able to fix https://github.com/wiremod/advduplicator/issues/65 and https://github.com/wiremod/advduplicator/issues/64

This is analog to: https://github.com/wiremod/advdupe2/pull/51

TomyLobo commented 9 years ago

uh, can't they just make a applydupeinfo hook to disintegrate the entity on paste?

Divran commented 9 years ago

Yes but that's not a clean solution

Grocel commented 9 years ago

@Divran: Do you mean that pull request or TomyLobo's solution?

@TomyLobo: The problem with deleting the entity on paste, that it would be too late already in some cases. This pull request was made to add the same filter features as Garry's duplicator has and to fix the linked bugs.

Divran commented 9 years ago

@Divran: Do you mean that pull request or TomyLobo's solution?

I meant tomylobo's

Nebual commented 9 years ago

Seems like a good idea, I say merge it.

Divran commented 9 years ago

Yeah fine by me

TomyLobo commented 9 years ago

If that's Garry's interface and we should be implementing it, so fine by me.

Grocel commented 9 years ago

OK, it's nice to hear that everything is seeming fine to merge. Is there anything left to clear?

TomyLobo commented 9 years ago

All except this one: https://github.com/Grocel/advduplicator/blob/master/lua/autorun/server/advdupe.lua#L716-L720 We can't have "do not steal" in an open source project also, typo in "compatable"

Divran commented 9 years ago

All except this one: https://github.com/Grocel/advduplicator/blob/master/lua/autorun/server/advdupe.lua#L716-L720 We can't have "do not steal" in an open source project

uh how long has that been there? It doesn't look like grocel's patch added that

TomyLobo commented 9 years ago

That is correct, however, it's still there and needs to go :)

Grocel commented 9 years ago

Thanks for merging.

Well, I wouldn't add such a thing to a pull request. I guess you can remove it yourself. :)

Also it seems you haven't noticed the patch for the Adv Dupe 2 in the OP yet. Can you check that out too?