Closed Grocel closed 9 years ago
uh, can't they just make a applydupeinfo hook to disintegrate the entity on paste?
Yes but that's not a clean solution
@Divran: Do you mean that pull request or TomyLobo's solution?
@TomyLobo: The problem with deleting the entity on paste, that it would be too late already in some cases. This pull request was made to add the same filter features as Garry's duplicator has and to fix the linked bugs.
@Divran: Do you mean that pull request or TomyLobo's solution?
I meant tomylobo's
Seems like a good idea, I say merge it.
Yeah fine by me
If that's Garry's interface and we should be implementing it, so fine by me.
OK, it's nice to hear that everything is seeming fine to merge. Is there anything left to clear?
All except this one: https://github.com/Grocel/advduplicator/blob/master/lua/autorun/server/advdupe.lua#L716-L720 We can't have "do not steal" in an open source project also, typo in "compatable"
All except this one: https://github.com/Grocel/advduplicator/blob/master/lua/autorun/server/advdupe.lua#L716-L720 We can't have "do not steal" in an open source project
uh how long has that been there? It doesn't look like grocel's patch added that
That is correct, however, it's still there and needs to go :)
Thanks for merging.
Well, I wouldn't add such a thing to a pull request. I guess you can remove it yourself. :)
Also it seems you haven't noticed the patch for the Adv Dupe 2 in the OP yet. Can you check that out too?
It should be able to fix https://github.com/wiremod/advduplicator/issues/65 and https://github.com/wiremod/advduplicator/issues/64
This is analog to: https://github.com/wiremod/advdupe2/pull/51