search

wiremod / wire-extras

Community Contributed Wire Extras Repository (formerly UWSVN). These are addons which may be of use to wiremodders but do not undergo the same level of critique that the official repos do.
Apache License 2.0
83 stars 66 forks source link

holoSetPose constantly flashing pose parameter #110

Closed diemarthaha closed 1 hour ago

diemarthaha commented 2 years ago

Whenever I use the function it either doesn't work, or just repeatedly flashes the animation for it. I've only used a TF2 model for this

https://user-images.githubusercontent.com/59637734/164960869-b7139e87-0e42-467c-80d4-0aa6db4559c1.mp4

.

thegrb93 commented 2 years ago

Can you provide some e2 code to test with?

diemarthaha commented 2 years ago

test.txt

thegrb93 commented 2 years ago

I found pose parameters have to get set every frame which kinda explains the flickering. As for why the pose parameter is messing with the animation. idk

SpaxscE commented 2 years ago

holosetpose in general is very broken ever since #64 when playing on servers

you also sometimes get: [wire-extras] addons/wire-extras/lua/entities/gmod_wire_expression2/core/custom/cl_holoanim.lua:34: table index is nil

  1. func - addons/wire-extras/lua/entities/gmod_wire_expression2/core/custom/cl_holoanim.lua:34
    1. unknown - lua/includes/extensions/net.lua:33

i reverted the changes of #64 on my private fork which makes holosetpose work flawless again. Its been broken for a very very long time someone should really look into this

thegrb93 commented 2 years ago

Sure we can revert it but #55 needs to be fixed at the same time.

thegrb93 commented 2 years ago

I went ahead and fixed that lua error

SpaxscE commented 2 years ago

i never had the issues of #55 back when it was reported. I still have multiple e2s from "back then" that have up to 5 holosetpose run at the same time that are now broken. I think it just has to be called on tick? Anyone who is going to use them will be calling them on tick anyway?

thegrb93 commented 2 years ago

Try the example code in it and if it isn't bugged anymore maybe gmod dev fixed and and this can be reverted.

SpaxscE commented 1 day ago

i dont need the example. I am capable of coding pose parameters myself and i have been using them for many years. Holo pose parameters is still completely broken when playing on servers on this official release. Please revert this change. The flickering has never been an real issue for anyone using it before this person reported it. It is now not working at all. We rather have some wierd flickering we can work around by calling it properly on tick like any animation is intended to be used than a non functioning function that it is now.

bro_pls_fix_its_broken_for_too_many_years.txt

thegrb93 commented 1 day ago

Hi, nice 2 years later. I'm not reverting because then people will complain about the revert causing the other issue to pop up. Whatever is broken needs to be debugged and fixed.

SpaxscE commented 22 hours ago

this version doesnt even have holosetpose anymore as it seems #131 and servers are using the workshop version of wiremod so this feature is completely gone now. Nobody else is using it or you would have been bombarded with reports. This feature does not work anymore test it yourself on any dedicated server you can find in the serverbrowser that uses this exact version.

I am using a custom version that still uses the original method that works completely fine to this day. Im sure the other few people that still care or use it are doing the same and dont even bother reporting it to you. The problem the OP had was already on a butchered version #64 . Issue #55 was never a problem in the first place if you used this thing correctly (see the E2 i posted)

Honestly, take a step back. Look at how this doesnt work at all right now (since 2019!!). And then think about how poseparameters are realistically used (made up test scenarios in bug report #55 vs actual ingame useage such as make vehicles steer, make wheels turn or making playermodels move/aim ect)

SpaxscE commented 20 hours ago

The more i dig, the deeper the rabbithole goes. So wiremod ITSELF does in fact have anim/setpose now, however it is not being uploaded to the workshop. https://github.com/wiremod/wire/pull/3113

Workshop reuploads of wire-extras still use the broken version of #64 and they sure will conflict with holoanim from wiremod itself once it is uploaded to workshop. What a complete disaster. This function will remain broken forever on the majority of servers.