search

wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
554 stars 332 forks source link

Move `table.*` to a Garry's Mod pull request #1033

Closed AbigailBuccaneer closed 5 years ago

AbigailBuccaneer commented 8 years ago

We currently add things like table.IsEmpty, that'd make more sense to be in Garry's Mod than Wiremod. Garry's Mod already adds a bunch of table.* functions, it'd be nice to add ours to there.

We also have similar functions like pairs_sortkeys that would be nice to get rid of too. Ideally we shouldn't be defining any globals other than WireLib.

Divran commented 8 years ago

:+1:

TomyLobo commented 8 years ago

make sure you rename table.Compact to table.Filter or table.Select

also find a better name for table.MakeSortedKeys like table.UselessFunctionNooneNeeds

And instead of PRing table.MakeNonIterable, make a bug report and post this as a workaround :)

oldmud0 commented 8 years ago

Meanwhile on the pull requests currently being taken care of over there:

tool.leafblower.desc=This tool is the most important aspect of Garry's Mod
thegrb93 commented 5 years ago

garrysmod doesn't merge PRs

bigdogmat commented 5 years ago

We can remove table.IsEmpty after the next update.