search

wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
551 stars 331 forks source link

Remove player restriction from entity:setSkin(number) #2988

Closed AshleyJamesy closed 4 months ago

AshleyJamesy commented 6 months ago

Followed similar pattern to how setMaterial and setSubMaterial are setup.

AshleyJamesy commented 6 months ago

@Denneisk

I think it's fine either way, just make a resolution to Vurv's suggestions.

What do I need to change to get this merged? Remove the unnecessary index checking as per below?

In Gmod an OOB skin doesn't check for validity and visually resets to 0 but with its value preserved at the set point. From what I understand, these checks could be removed since it doesn't seem to cause issues.

Denneisk commented 6 months ago

What do I need to change to get this merged? Remove the unnecessary index checking as per below?

That or use Vurv's suggestions.

AshleyJamesy commented 6 months ago

@Denneisk Done

j7gg commented 5 months ago

so is this added yet?

Denneisk commented 5 months ago

Don't wanna go alone against Vurv since I'm still new :P

Denneisk commented 5 months ago

Will probably merge this at the start of next month if no word from either :P