search

wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
551 stars 331 forks source link

Wire Ballon Deployer game crash #2994

Closed Astralcircle closed 6 months ago

Astralcircle commented 6 months ago

Describe the bug If you set the Ballon Deployer Force too high, the game will crash

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Entities-->Wiremod'
  2. Spawn 'Wire Ballon Deployer'
  3. Set Force to 99999999999999999999999999999999999999999999999999999999999999999999999999999999999
  4. Activate it

Expected behavior Set the Force limit to approximately 1,000,000

Video https://youtu.be/YeckL2h36wo (Maybe YouTube hasn't processed it yet)

thegrb93 commented 6 months ago

You have sv_crazyphysics cvars turned off I think. There's millions of ways to crash the game if those are turned off. I tried it and it didn't crash the game with those cvars turned on for me.

Astralcircle commented 6 months ago

I just checked the convars on my server and all convars like sv_crazyphysics were enabled, but it still crashes my server

thegrb93 commented 6 months ago

Give me an e2 to reproduce it then, I'm not counting all those 9s.

Astralcircle commented 6 months ago

In general, it is enough to enter a lot of nines, but here is the code

@name @inputs @outputs A @persist @trigger @strict

A = 99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999

Vurv78 commented 6 months ago

In general, it is enough to enter a lot of nines, but here is the code

@name @inputs @outputs A @persist @trigger @strict

A = 99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999

That's just _INF. Should probably have a warning for number literals that are greater than what lua can actually store

thegrb93 commented 6 months ago

Still didn't crash. I just get

Crazy origin, velocity on entity [73][gmod_balloon]
    Origin:           [-41.883915, -211.789429, nan]
    Angles:           [0.000000, 0.000000, 360.000000]
    Velocity:         [0.000000, 0.000000, nan]
    Angular Velocity: [0.000000, 0.000000, -0.000000]
Defusing!
Removing!
Crazy origin, velocity on entity [73][gmod_balloon]
    Origin:           [-41.793987, -211.789429, nan]
    Angles:           [0.000000, 0.000000, 360.000000]
    Velocity:         [0.000000, 0.000000, nan]
    Angular Velocity: [0.000000, 0.000000, -0.000000]
Defusing!
Removing!
thegrb93 commented 6 months ago

Maybe multiplayer is more susceptible to crashing?

Astralcircle commented 6 months ago

Perhaps it is so