search

wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
553 stars 332 forks source link

beingLookedAtByLocalPlayer() is nil #3045

Closed legokidlogan closed 5 months ago

legokidlogan commented 5 months ago

After #3012, clients occasionally error with attempt to call upvalue 'beingLookedAtByLocalPlayer' (a nil value) under various circumstances.

A few stack traces:

1.  BeingLookedAtByLocalPlayer - addons/wire/lua/entities/base_wire_entity.lua:233
 2.  DoNormalDraw - addons/wire/lua/entities/base_wire_entity.lua:252
  3.  unknown - addons/wire/lua/entities/gmod_wire_button.lua:22
1.  BeingLookedAtByLocalPlayer - addons/wire/lua/entities/base_wire_entity.lua:233
 2.  DoNormalDraw - addons/wire/lua/entities/base_wire_entity.lua:252
  3.  Draw - addons/wire/lua/entities/base_wire_entity.lua:22
   4.  DrawTranslucent - gamemodes/base/entities/entities/base_anim.lua:49
    5.  unknown - addons/wire/lua/entities/gmod_wire_lamp.lua:21
1.  BeingLookedAtByLocalPlayer - addons/wire/lua/entities/base_wire_entity.lua:233
 2.  DoNormalDraw - addons/wire/lua/entities/base_wire_entity.lua:252
  3.  unknown - addons/wire/lua/entities/base_wire_entity.lua:22

All of which end up here.

Denneisk commented 5 months ago

I believe Initialize gets overwritten by multiple entities without calling BaseClass.Initialize so this value never gets initialized.

thegrb93 commented 5 months ago

Can we just revert that dumb local. I'm not a fan of it.

Denneisk commented 5 months ago

No no no we can save it #3046