wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
547 stars 332 forks source link

Fix issues involving math.tau #3054

Closed Denneisk closed 2 months ago

Denneisk commented 2 months ago

Many users have been complaining about the number extension suddenly not working. This is because some servers don't have math.tau defined on them for whatever reason. This PR presents a twofold solution:

  1. It sets a fallback for math.tau when it is undefined.
  2. It ensures any future invalid constants will not cause extensions to fail loading.

Changes:

Updated error form (note E2 executes extension files twice): New errors

Denneisk commented 2 months ago

Messed up something with the git history whatever

Grocel commented 2 months ago

This is because some servers don't have math.tau defined on them for whatever reason.

That's because GMod updates are optional on servers, so servers are outdated sometimes. The math.tau constant was added in last main update. Rubat's tip toeing around net compatibility makes it possible that server could be outdated by 2+ years and still be able to connect to. Good luck accounting for those servers in addon code on the long run.