wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
553 stars 332 forks source link

[SERVER SPECIFIC DISREGARD] Wire Textscreen FGColor and BGColor do not Update the Screen #3070

Closed snepderg closed 4 months ago

snepderg commented 4 months ago

Please note: This issue tracker is for bug reports If your issue isn't a bug report, or if you are unsure whether it's a bug, please go to our discord channel instead at https://discord.gg/H8UKY3Y If you are confident your issue is a bug, please fill in as much information as you can below.

Describe the bug Wire Text Screen inputs for FGColor and BGColor are not updating the colour on the screen.

To Reproduce Steps to reproduce the behavior:

  1. Spawn a Wire Text Screen with some text.
  2. Wire a Vector input to FGColor or BGColor with a different value than what is set in the tool.
  3. Notice how the colour does not change.

Expected behavior FGColor should update the text colour and BGColor should update the background colour.

Screenshots (Notice that I spawned the text screen with the colour set to Red, and I'm trying to change it to Green).

(Debug and Screen) gmod_zU9q1lQnD4

(Debug) gmod_7SCKm9Stga

(Constant Value) gmod_dp2iyf57zC

snepderg commented 4 months ago

Not really sure why it displays RGB: 0, 255, 0 as 0, 0, 255 but maybe I don't know how Vectors work in Wire.

Denneisk commented 4 months ago

Every number is displayed to 1 decimal point. The value is displaying correctly in the debugger.

snepderg commented 4 months ago

Ahhh, ok yeah I didn't look closely enough.

Denneisk commented 4 months ago

I was only able to replicate this bug after

  1. Placing a text screen
  2. Setting its color using a constant value
  3. Updating the text screen using the tool gun with a different color
  4. Trying to update the constant value using the tool gun with the same color the constant value had previously

With normal wiring and when the color changes, I don't see this effect.

snepderg commented 4 months ago

Huh, interesting. For me, the constant value won't set the colour at all. I was directed here as it was assumed a Wire issue and not a server-specific issue.

Do let me know if there is anything I can check for you.

Update: Alright, I just checked for myself in a Local server with basically just Wiremod enabled (Sorry for not checking this sooner). I can update the text screen colour just fine, I also confirmed that the behaviour of updating the screen with the tool and updating the constant value with the same value as previously set does what you said.

Looks like this one's a server specific issue, Next time I will check if I can replicate it locally before assuming it's a problem with the repo.