Closed deltamolfar closed 3 months ago
Looks fine, might do a diff against starfall's to sanity check.
Diffed the changes and they mostly look ok. The gmod_wire_value code is pretty messy, but whatever.
Regarding gmod_wire_value code is messy because I didn't like how it was implemented in sf, so I've decided to expand the value setting logic, while leaving support for the sf way. Code is messy, but I'm not sure how to make it cleaner without separating logic into few, never reused functions out of gmod_wire_value's preFactory. I think it's fine to leave it as is for now, as it will not really harm any future work, and maybe someday someone, or me, will refactor that.
(Re-PR because I accidentally deleted previous fork) Added
:GetBool()
, and review changes.wire_expression2_propcore_whitelist <= 0
)Expression2_CanEffect
While most of registration code/logic is from starfall
prop_sent.lua
, I've found and fixed ~10 sents + added ~6 that weren't originally there.Current minor bugs:
E2 sent (classname)
, bute2_spawned_sent
when user cancels sent.