search

wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
549 stars 333 forks source link

Use vector_origin instead of Vector(0, 0, 0) #3111

Closed Astralcircle closed 1 month ago

Astralcircle commented 1 month ago

I just replaced Vector(0, 0, 0) with vector_origin everywhere. And also slightly changed the structure of the code

thegrb93 commented 1 month ago

Yeah, was about to close this. These places aren't good places for vector_origin since they could get modifed.

DerelictDrone commented 1 month ago

Yeah, was about to close this. These places aren't good places for vector_origin since they could get modifed.

They did change some other spots, replacing constraintcore's emptyvector const with vector_origin, I'm not sure if the mocktrace struct could potentially get modified here, the PR could have probably been salvaged

Astralcircle commented 1 month ago

Well at least I tried ¯_ツ_/¯

thegrb93 commented 1 month ago

Yeah, I guess the constraint core ones can be merged. If you want to do that