wiremod / wire

Garry's Mod add-on that allows users to wire up components in order to make more elaborate automatic and user-controlled contraptions.
http://www.wiremod.com
Apache License 2.0
549 stars 333 forks source link

E2 Editor Layer issue #760

Closed Codingale closed 8 years ago

Codingale commented 9 years ago

So a while back, about 1 or two years ago I had this issue, hadn't paid it much attention nor wanted to go through the effort of fixing it until now when I need those tabs.

This happens somewhat randomly and a restart/rejoin normally fixes it. I can't begin to think where it's coming from.

Image of remote updater layered wrong. Image of credits layered wrong.

Divran commented 9 years ago

the fuck

I've never seen anything like it, and I've literally used E2 for thousands of hours

Are you sure it happens randomly? There's no way to reliably reproduce it?

Codingale commented 9 years ago

Haha, very professional. I don't know. It just.. happens. It's not like there's a error with a stack trace. I am using the github version (it happen with the workshop version too) and I've had the issue at least since May assuming my "1-2 years" guess is off.

It might happen after opening a few E2s closing them changing window size moving or something.

If you want I can try to reproduce it but I'm not sure how it happens in the first place. I'd be glad to help though. I haven't payed much attention to how it works if it turns into that after working fine or it's like that from connect.

ghost commented 9 years ago

I've seen this bug too, but this exact behavior rarely happend to me. The most often is contents of tabs from settings menu compressed to very thin line in such a way that you can't either see or edit any of settings.

Also there are some bugs with tabs spacing. First of all, all tabs start from wrong x offset - they are always a little (3-4pixels) left. Next, every time you rename some e2 in tab with shorter name, then click on other tab, then click on that tab again, so it will update tab name, tab which is at right will remain same offset, so u will get free space between tabs. Oh, and more: I don't know how to reproduce it, but in some cases editor window resize regions also becomes offsetted to left or right and/or up or down by about 3-10pixels. Sometimes this makes impossible to resize fullscreen'd editor when running gmod in window, and every time it makes it harder to resize. Maybe regions also become thinner, but I'm not sure. And more: in "Editor" and "Expression 2" tabs of settings there are no background for sliders "darkness" and "Browser Width" and in "Other color options" there is 1 (but actually I think there are 3 or 4 of them) number input field (first at left from type selector) which behaves strange and probably just needs to be deleted.

P.S.: highlighting bugs coming...

Divran commented 9 years ago

The bug where it gets compressed to a thin line can be fixed by resizing the window.

The gaps between tabs when you rename them etc can be fixed by creating a new tab and then closing it.

Spamming timers would probably fix these problems. Timers solve everything.

AlexanderArvidsson commented 9 years ago

"Next, every time you rename some e2 in tab with shorter name, then click on other tab, then click on that tab again, so it will update tab name, tab which is at right will remain same offset, so u will get free space between tabs." We just fixed that bug, been irritating me for a while.

ghost commented 9 years ago

Yes, but only sometimes. Same applies to re-opening that tab. In maybe 3/4 of cases it gets fixed.

Divran commented 9 years ago

https://github.com/wiremod/wire/commit/16cd376892453f22533ed61afe043a76a7dbfd94

Divran commented 9 years ago

I haven't been able to fix the tabs being too far left, and I can't fix the original problem this thread is about because I've never even seen it.

Codingale commented 9 years ago

Honestly I haven't played Garry's Mod since making the issue, I'll test a few ideas soon but I'm having to take care of someone for a few days and haven't had the time.

That commit is also another issue I was planning on making since that bugged for a long time also but it's a easier fix client side than rejoining/restarting. I normally have to close the offending tab then reopen it to fix it however it's not a high priority.

Codingale commented 9 years ago

Was able to reproduce sometime in a 12 hour play session on Garry's mod, I don't know when, I was alt tabbing and only checking a few times per hour or two.

Closing and reopening the windows/buttons do not fix it, not sure how to reproduce still. Still trying.

Codingale commented 9 years ago

And again but this time about 3 hours into the session I went to check to upload my code remotely and it done that again.

Divran commented 9 years ago

Sorry, but I can't fix what I can't reproduce. Try running wire_expression2_reloadeditor every time it happens. That should be an easy fix.

AbigailBuccaneer commented 8 years ago

Let's assume this doesn't happen any more (as almost the entire UI was overhauled). Feel free to reopen if it does.