search

wirepair / gcd

Unofficial implementation of the Google Chrome Remote Debugger in Go
MIT License
186 stars 31 forks source link

Fix error message #54

Closed camswords closed 3 years ago

camswords commented 3 years ago

Fixes an error that produces a message like: Unable to contact debugger at http://localhost:38479/json after 15000000000 seconds, gave up.

The suggested fix changes the error to: Unable to contact debugger at http://localhost:38479/json after 15s, gave up.

wirepair commented 3 years ago

Thanks for the PR! Do you mind bumping https://github.com/wirepair/gcd/blob/master/v2/gcd.go#L47 to the next minor release? then I can just tag -> make new release.

Sorry for the ghetto versioning!

camswords commented 3 years ago

Sorry for the ghetto versioning!

Whatever works! Bumped the minor version as requested 👍

wirepair commented 3 years ago

@camswords i'm an idiot and meant patch version not minor, but i just created a new PR since I had to update the change log anyways, will release 2.2.2 in a moment here.

camswords commented 3 years ago

I did wonder, but I dutifully followed your instructions! 😂