search

wirepair / gcd

Unofficial implementation of the Google Chrome Remote Debugger in Go
MIT License
186 stars 31 forks source link

Update to Chromium 127.0.6533.88 #75

Open eatdrinksleepcode opened 3 months ago

eatdrinksleepcode commented 3 months ago
  1. Downloaded the latest browser_protocol.json file from here
  2. Removed "\n" sequences from the file and minified it (to match what I think was also done in previous updates)
  3. Not sure what "Make sure there aren't any string encoded bools (usually hidden or optional fields)" meant from the README; it didn't seem to cause a problem 🤷‍♂️
wirepair commented 2 months ago

Ahh this is annoying, looks like chromium shut down https://omahaproxy.appspot.com/all.json which is what gcdapigen used to pull down the latest versions. We need to fix the apigen stuff as doing this downloading of json manually is error prone.

wirepair commented 2 months ago

We can get this merged in without updating/fixing gcdapigen, but can you fix the test and example app that are throwing errors?

Then I can get this merged in and bump the release.

/gcd_test.go:624:4: unknown field 'PostData' in struct literal of type gcdapi.FetchContinueRequestParams

Error: examples/screenshot/screenshot.go:105:14: assignment mismatch: 2 variables but page.CaptureScreenshotWithParams returns 1 values
eatdrinksleepcode commented 1 month ago

@wirepair Both of the test errors are happening because of pieces that have been removed from the generated code (a field in a request object, and a return value in a method call). Except that I think in both cases those removals are incorrect.

  1. PostData field was removed from FetchContinueRequestParams but is still present in CDP.
  2. The response value was removed from Page.CaptureScreenshotWithParams but is (obviously) still present in CDP.

I'm not sure what's causing these incorrect removals, or if there are similar incorrect changes that are not being caught by tests.

idawson-gl commented 1 month ago

I'll take a look today to see what is happening with the generator code

wirepair commented 4 weeks ago

Going to close this in favor of https://github.com/wirepair/gcd/pull/77 as this updates gcdapigen to pulldown the latest protocol.json file from the ToT.