Longer timeout for windows when connecting to remote instance

wirepair / gcd

Unofficial implementation of the Google Chrome Remote Debugger in Go

MIT License

186 stars 31 forks source link

Longer timeout for windows when connecting to remote instance #9

Closed fgeertsema closed 8 years ago

fgeertsema commented 8 years ago

A new pull request for connecting to a remote chrome instance.

The test TestConnectToInstance is now passing on Windows. I have tested it with the windows 10 image from https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ on virtual box with 8 GB memory and 4 cpu's and 80 mb video memory.

To let it pass all tests on the virtual machine I needed to increase the timeout as shown in the diff attached, this isn't in the pull request.

wirepair commented 8 years ago

Awesome! Thank you for taking the time to setup that VM and test this. I just tested it in windows and it passess now. So weird it takes 13 seconds in windows on my machine, yet .90s in osx? Very strange. Anyways thanks again!